Add and configure Sentry gem #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPrevost
requested changes
Nov 25, 2024
config/initializers/sentry.rb
Outdated
| return unless ENV.has_key?('SENTRY_DSN') | ||
| config.dsn = ENV.fetch('SENTRY_DSN') | ||
| config.breadcrumbs_logger = [:active_support_logger, :http_logger] | ||
| config.enable_tracing = true |
There was a problem hiding this comment.
Let's not enable tracing via Sentry at this time. We should get the same/similar data via Scout. If we want to move that to Sentry instead we can discuss, but don't need to have both on for now.
Gemfile
Outdated
| @@ -69,6 +69,11 @@ gem 'rack-cors' | |||
| # Use Redis adapter to run Action Cable in production | |||
| # gem "redis", ">= 4.0.1" | |||
|
|
|||
| # Sentry integration according to their documentation [https://docs.sentry.io/platforms/ruby/guides/rails/] | |||
| gem "stackprof" | |||
There was a problem hiding this comment.
stackprof is only required if we enable profiling and/or tracing. I think for now we should leave both off and remove this gem.
|
No worries - the big reason this wasn't in review yet was because I was wanting to troubleshoot why the messages weren't showing up in Slack yet. That doesn't seem like something that would affect these code changes, though. |
JPrevost
approved these changes
Nov 25, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Sentry integration, similarly to what we've done with other applications and the current Sentry documentation.
Developer
Ticket(s)
https://mitlibraries.atlassian.net/browse/TCO-88
Accessibility
all issues introduced by these changes have been resolved or opened
as new issues (link to those issues in the Pull Request details above)
Documentation
ENV
Stakeholders
Dependencies and migrations
YES dependencies are updated
NO migrations are included
Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing